-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Dashboard v0.0.1 w/ Polymer3 + Webpack #2576
Conversation
- Fixed webpack for windows (components/ is not a valid path in windows) - Spacing and semicolons matched to old-codebase - Added cross-platform support to npm run targets - Added missing dep (babel/polyfill) - Dashboard build version is now corrected and hover will reveal kubeflow vs Dashboard versions - Pug fixed to match syntax for empty-value attributes - Updated webpack for readability
@avdaredevil: GitHub didn't allow me to assign the following users: prodonjs. Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
… now have messages, also dirty git output now has a warning during build
This version also fixes broken dashboard image in production /assign @zhenghuiwang And @prodonjs this is what the new versions manifest as: |
/assign @yebrahim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies on not being considerate of Windows. I didn't really need to include the components path for pug anyways, but it is necessary for the CSS imports that live with our components.
I feel pretty strongly that we need to choose a commonly accepted style guide and Google's seems standard enough to be comfortable for any contributors and matches what most other organizations suggest. I especially feel like removing semi-colons is a something we should avoid as evidenced by both the Google and popular AirBnB style guides.
@@ -28,6 +28,7 @@ | |||
}, | |||
"homepage": "https://github.com/kubeflow/kubeflow#readme", | |||
"dependencies": { | |||
"@babel/polyfill": "^7.2.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is needed. I know there is the warning in the webpack build process but I think the fact that we are providing the dependencies through the webcomponents-loader.js makes it a moot point. At best I think it would be a devDependency though and not in our primary deps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind. I think I overestimated the scope of the webcomponents polyfills as also including standard polyfills for ES6. I do think we still need to import @babel/polyfill
in our entry point.
I've added that to my PR #2579. Feel free to merge the applicable changes from that into this change, or if you want to approve, we can merge that into master first and then your change will only be to fix the Windows specific stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's merge yours, since it addresses a bug, and then this can be a feature merge.
@@ -1,79 +1,78 @@ | |||
import { PolymerElement, html } from '@polymer/polymer/polymer-element.js'; | |||
import {PolymerElement, html} from '@polymer/polymer/polymer-element.js' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel pretty strongly that this is not something we should change. We should follow a commonly accepted standard and in this case I think it makes sense to choose the Google JS Style guide which explicitly requires semi-colons.
There's an eslint configuration we can add to enforce this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big plus one here.
const COMPONENTS = resolve(SRC, 'components'); | ||
const DESTINATION = resolve(__dirname, 'dist', 'public'); | ||
const WEBCOMPONENTS = './node_modules/@webcomponents/webcomponentsjs'; | ||
const ENV = process.env.NODE_ENV || 'development' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be discouraged by the Google style guide.
https://google.github.io/styleguide/jsguide.html#formatting-horizontal-alignment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for following Google's style guide.
@@ -1,79 +1,78 @@ | |||
import { PolymerElement, html } from '@polymer/polymer/polymer-element.js'; | |||
import {PolymerElement, html} from '@polymer/polymer/polymer-element.js' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big plus one here.
- Server port fixed to 8082 which is what is needed for GKE deployment - Refactored some code
@@ -61,6 +61,7 @@ | |||
"clean-webpack-plugin": "^1.0.1", | |||
"concurrently": "^4.1.0", | |||
"copy-webpack-plugin": "^5.0.0", | |||
"cross-env": "^5.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed that the terser-webpack-plugin got added to deps instead of devDeps. Can you move that in this commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
/test all |
@@ -3,7 +3,7 @@ | |||
// @description centraldashboard Component | |||
// @shortDescription centraldashboard | |||
// @param name string Name | |||
// @optionalParam image string gcr.io/kubeflow-images-public/centraldashboard:v20190223-v0.4.0-rc.1-152-g1de09b7a Image for the central dashboard | |||
// @optionalParam image string gcr.io/kubeflow-images-public/centraldashboard:v20190301-v0.4.0-rc.1-183-g07eecd2f Image for the central dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question, does this comment need to be updated with every subsequent release? Wouldn't a user typically just want to deploy the gcr.io/kubeflow-images-public/centraldashboard:latest or search for their specific tag during development?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we definitely don't like pushing to :latest
, though there is a make recipe for it (@jlewi can possibly elaborate on why that is). But no we don't generally make an update everytime. But because the last 2 images were broken (bower deps were missing, and wrong port was being used). This release fixes both those issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the latest comments are resolved. LMK if the explicit specification of the eslint configuration file addresses the build issues on Windows.
@prodonjs: changing LGTM is restricted to assignees, and only kubeflow/kubeflow repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @prodonjs |
@prodonjs: GitHub didn't allow me to assign the following users: prodonjs. Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@prodonjs: changing LGTM is restricted to assignees, and only kubeflow/kubeflow repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @prodonjs |
@prodonjs: GitHub didn't allow me to assign the following users: prodonjs. Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jlewi I am good with AP's latest changes. I thought I had been added to the org last week when my PR to internal-acls was approved. I guess I didn't receive the invite yet as indicated in https://www.kubeflow.org/docs/about/contributing/#joining-the-kubeflow-github-org. |
/hold cancel |
* Multiple issues tackled: - Fixed webpack for windows (components/ is not a valid path in windows) - Spacing and semicolons matched to old-codebase - Added cross-platform support to npm run targets - Added missing dep (babel/polyfill) - Dashboard build version is now corrected and hover will reveal kubeflow vs Dashboard versions - Pug fixed to match syntax for empty-value attributes - Updated webpack for readability * Added babel-polyfill to runtime deps rather than dev deps * [Windows-only] Color coded all make output, Tag check added, failures now have messages, also dirty git output now has a warning during build * Updated new dashboard reference :v20190227-v0.4.0-rc.1-176-g738de035 * Fixed Multiple changes: - Server port fixed to 8082 which is what is needed for GKE deployment - Refactored some code * Final working state for new image * TS Changes * Build updated to match latest :v20190301-v0.4.0-rc.1-183-g07eecd2f * Migrated dev dependency to correct location * Uncommented linter, fixed PR comments from @prodonjs
* Multiple issues tackled: - Fixed webpack for windows (components/ is not a valid path in windows) - Spacing and semicolons matched to old-codebase - Added cross-platform support to npm run targets - Added missing dep (babel/polyfill) - Dashboard build version is now corrected and hover will reveal kubeflow vs Dashboard versions - Pug fixed to match syntax for empty-value attributes - Updated webpack for readability * Added babel-polyfill to runtime deps rather than dev deps * [Windows-only] Color coded all make output, Tag check added, failures now have messages, also dirty git output now has a warning during build * Updated new dashboard reference :v20190227-v0.4.0-rc.1-176-g738de035 * Fixed Multiple changes: - Server port fixed to 8082 which is what is needed for GKE deployment - Refactored some code * Final working state for new image * TS Changes * Build updated to match latest :v20190301-v0.4.0-rc.1-183-g07eecd2f * Migrated dev dependency to correct location * Uncommented linter, fixed PR comments from @prodonjs
* Multiple issues tackled: - Fixed webpack for windows (components/ is not a valid path in windows) - Spacing and semicolons matched to old-codebase - Added cross-platform support to npm run targets - Added missing dep (babel/polyfill) - Dashboard build version is now corrected and hover will reveal kubeflow vs Dashboard versions - Pug fixed to match syntax for empty-value attributes - Updated webpack for readability * Added babel-polyfill to runtime deps rather than dev deps * [Windows-only] Color coded all make output, Tag check added, failures now have messages, also dirty git output now has a warning during build * Updated new dashboard reference :v20190227-v0.4.0-rc.1-176-g738de035 * Fixed Multiple changes: - Server port fixed to 8082 which is what is needed for GKE deployment - Refactored some code * Final working state for new image * TS Changes * Build updated to match latest :v20190301-v0.4.0-rc.1-183-g07eecd2f * Migrated dev dependency to correct location * Uncommented linter, fixed PR comments from @prodonjs
…forms' (#2547) * revert to prior version * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'kfctl - Fetch registry automatically' * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * change DefaultDevRepo to point to just the repo not repo/kubeflow * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * plugins for all existing KfApp instances {ksonnet, minikube, foo}. * update golang version * fixes 'docker-for-desktop' * delete meta-controller-cluster-role-binding * update README.md * remove unused var DEBUG * remove bootstrap/cmd/plugins/foo.go * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'add the gcp platform to kfctl (golang)' * fix merge conflict * cli option --project is an init flag * fix to write out project to app.yaml * fix for nil project check * include fix for #2367 * added updateDM, createSecrets to Apply * fixes to macros * merge changes from upstream master * remove old files, update README.md * fix for init app-name where app-name is not a path * fix for gcp apply * code to create a Gcp Secret, doesn't do correct auth right now * snapshot * update on downloadK8sManifests, gcpInitProject, added TODO's * additional work on gcpInitProject * gcpInitProject now works but requires GOOGLE_APPLICATION_CREDENTIALS env var * initial pass on updateDeployment * update README.md to described static vs dynamic platforms * updates to Gcp.updateDM, added GOOGLE_APPLICATION_CREDENTIALS to the Makefile tests * minor changes on init, generate usage * snapshot * additional global resources identified * do not delete scalingpolicies * change default platform to ksonnet * default --version to master until 0.5.0 * remove verbose from spark-operator apply * address comments from Jeremy * address comments from Jeremy * fixes #2537, refer to no platform as 'none' * add general test for kfctl in Makefile that also tests the plugin capability * remove kftcl config since we now have bootstrap config, fix for DefaultPlatform="none" * change test of platform none to create directory none, updated README * remove reference to docker-for-desktop * update README.md, remove --debug flag (not used) * fixes 'kfctl (golang) Simplify the child/parent relationships in platforms' * fix backendconfig name (#2542) * fix backendconfig name * fix test * pin to the latest verified tf-operator commit in order to enable changes in tf-operator HEAD whcih likely break kubeflow checkout tests * fix (#2506) * Added unit tests for GetUpdatedPolicy at gcpUtils.go - bootstrap/app (#2516) * Added tests for 'GetUpdatedPolicy' - bootstrap/app * Fix typo - gcpUtils_test.go * Added a windows equivalent script for the makefile for central-dashboard (#2518) * update katib component (#2553) * Refactor for Express + Webpack build stack. (#2572) * Refactor for Express + Webpack build stack. - Add webpack to process front-end code in public/ - Add TS and Express for server backend - Update Dockerfile to run the server as Node. - Fix issue with external links. * Updates based on feedback * address review comments * move tests under test directory * Add ESLint to enforce Google JS style in public/ (#2579) * Add ESLint to enforce Google JS style in public/ * Switch to 4 space tabs * Updating python package imports related to tf-operator (#2581) * updated tf-operator imports * fixed a typo * fixed a typo * Profiles e2e test (#2404) * profiles e2e test * fix * review comment * fix * fix * fix * fix * add retry * fix * Update the jupyter-web-app Image (#2589) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * Golang profile controller (#2533) * init * create api * wip * fix * fix * fix * fix test * address review * fix test * make it cluster scope * fix test * fix test * fix * turnoff jupyter images authentication (#2591) * Updated Jupyter image paths for using in notebook controller (#2552) * updated jupyter image paths for using in notebook conroller * removed 1.4.1 image from the list of options * updated jupyter image tags to point to the latest verified ones * updated jupyter images to allow any origin (#2606) * Removing prune for Subresource field in CRD (#2598) * Adding backOffLimit field to metric collector spec (#2597) * remove global resources by label rather than listing all and looking for the label * mv client to coordinator * Fixed Dashboard v0.0.1 w/ Polymer3 + Webpack (#2576) * Multiple issues tackled: - Fixed webpack for windows (components/ is not a valid path in windows) - Spacing and semicolons matched to old-codebase - Added cross-platform support to npm run targets - Added missing dep (babel/polyfill) - Dashboard build version is now corrected and hover will reveal kubeflow vs Dashboard versions - Pug fixed to match syntax for empty-value attributes - Updated webpack for readability * Added babel-polyfill to runtime deps rather than dev deps * [Windows-only] Color coded all make output, Tag check added, failures now have messages, also dirty git output now has a warning during build * Updated new dashboard reference :v20190227-v0.4.0-rc.1-176-g738de035 * Fixed Multiple changes: - Server port fixed to 8082 which is what is needed for GKE deployment - Refactored some code * Final working state for new image * TS Changes * Build updated to match latest :v20190301-v0.4.0-rc.1-183-g07eecd2f * Migrated dev dependency to correct location * Uncommented linter, fixed PR comments from @prodonjs * updated jupyter images based on postsubmit results of 97b94c0 (#2611) * Adding additional printer columns to display status (#2609) * Adding additional printer columns to display status * Fixing tests * Semi-working kfctl go binary (#2587) * Add flag --skip-init-gcp-project * fix gcpInitProject * update error msg * add deployment creation logic * fix bugs on generateDMData * fix bugs * add default config to ipName and hostName * fix bugs on app.yaml * add Fingerprint to update deployment * make network and gcfs as DM optional * add todos * add iam policy handlers * finish patch iam policy * adding poll op to dm api calls * add gke api version * temp * change mysqlPd/nfsPd names * remove * temp * add config types * add basic auth flag * move config to gcp * link use basic auth flag to generate * use basic auth to determine config path * change to gabrielwen repo for now * change config on the fly * change repo path * create new Genereate method * add required packages * implement NewGenerate * clean up default config and add on-the-fly configs * move config handling to ksonnet.go * add ks param set * add application as component * fix typo * add simple TargetConfiguration factory * add fixed backof * temp * fix from merge * make namespace in gke * bind user as default-admin in gke * finish createSecrets * write oauth secret * uncomment ks apply * add ks show * add ks apply logic to k8sutils * uncomment deployment * build rest.Config from remote * impersonate as admin for rbac * use remote config as REST client config * update default.yaml path * complete apply logic * add retry * add ignore * merge * remove temp comment * use backoff in gcp * remove progress as it is not updating * use backoff * use backoff * use default zone * fix zone config * add doc * add doc * update Makefile * fix flag doc * fix * doc * doc * add doc * sort packages and component names * shell out to gcloud and kubectl for now * remove some configs * fix * remove GkeApiVersion * add todo * add notebook-controller back * change names * updates * add field InitRequired * remove KsInitParams * migrate * Add status to notebook (#2558) * wip * wip * update test to check status condition * fix * Add prodonjs to OWNERS (#2613) * Changed sidebar tab from JupyterHub to Notebooks (#2619) * fix (#2620) * pf gcb (#2603) * Setting the base_url flag of Jupyter images (#2627) * set base_url of jupyter * change the env base_url to NB_PREFIX to sync with #2620 * fix (#2631) * resolve merge conflicts from upstream/master, fix error on master when --platform=none or not specified * store non exist parameter differently (#2625) * fix (#2632) * update pipeline system images to 0.1.12 release (#2637) * updated jupyter image paths to point to the latest ones (#2638) * add retry around ks init (#2643) * add retry around ks init * update comments * merge errors * Getting started card completed (#2651) * Getting Started card content added, and un-hidden. Windows support added in webpack to run dev builds * Getting Started card fully implemented from mocks * Spaced out cards a little more * Got eslint working! And fixed eslint issues in webpack
…forms' (kubeflow#2547) * revert to prior version * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'kfctl - Fetch registry automatically' * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * change DefaultDevRepo to point to just the repo not repo/kubeflow * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * plugins for all existing KfApp instances {ksonnet, minikube, foo}. * update golang version * fixes 'docker-for-desktop' * delete meta-controller-cluster-role-binding * update README.md * remove unused var DEBUG * remove bootstrap/cmd/plugins/foo.go * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'add the gcp platform to kfctl (golang)' * fix merge conflict * cli option --project is an init flag * fix to write out project to app.yaml * fix for nil project check * include fix for kubeflow#2367 * added updateDM, createSecrets to Apply * fixes to macros * merge changes from upstream master * remove old files, update README.md * fix for init app-name where app-name is not a path * fix for gcp apply * code to create a Gcp Secret, doesn't do correct auth right now * snapshot * update on downloadK8sManifests, gcpInitProject, added TODO's * additional work on gcpInitProject * gcpInitProject now works but requires GOOGLE_APPLICATION_CREDENTIALS env var * initial pass on updateDeployment * update README.md to described static vs dynamic platforms * updates to Gcp.updateDM, added GOOGLE_APPLICATION_CREDENTIALS to the Makefile tests * minor changes on init, generate usage * snapshot * additional global resources identified * do not delete scalingpolicies * change default platform to ksonnet * default --version to master until 0.5.0 * remove verbose from spark-operator apply * address comments from Jeremy * address comments from Jeremy * fixes kubeflow#2537, refer to no platform as 'none' * add general test for kfctl in Makefile that also tests the plugin capability * remove kftcl config since we now have bootstrap config, fix for DefaultPlatform="none" * change test of platform none to create directory none, updated README * remove reference to docker-for-desktop * update README.md, remove --debug flag (not used) * fixes 'kfctl (golang) Simplify the child/parent relationships in platforms' * fix backendconfig name (kubeflow#2542) * fix backendconfig name * fix test * pin to the latest verified tf-operator commit in order to enable changes in tf-operator HEAD whcih likely break kubeflow checkout tests * fix (kubeflow#2506) * Added unit tests for GetUpdatedPolicy at gcpUtils.go - bootstrap/app (kubeflow#2516) * Added tests for 'GetUpdatedPolicy' - bootstrap/app * Fix typo - gcpUtils_test.go * Added a windows equivalent script for the makefile for central-dashboard (kubeflow#2518) * update katib component (kubeflow#2553) * Refactor for Express + Webpack build stack. (kubeflow#2572) * Refactor for Express + Webpack build stack. - Add webpack to process front-end code in public/ - Add TS and Express for server backend - Update Dockerfile to run the server as Node. - Fix issue with external links. * Updates based on feedback * address review comments * move tests under test directory * Add ESLint to enforce Google JS style in public/ (kubeflow#2579) * Add ESLint to enforce Google JS style in public/ * Switch to 4 space tabs * Updating python package imports related to tf-operator (kubeflow#2581) * updated tf-operator imports * fixed a typo * fixed a typo * Profiles e2e test (kubeflow#2404) * profiles e2e test * fix * review comment * fix * fix * fix * fix * add retry * fix * Update the jupyter-web-app Image (kubeflow#2589) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * Golang profile controller (kubeflow#2533) * init * create api * wip * fix * fix * fix * fix test * address review * fix test * make it cluster scope * fix test * fix test * fix * turnoff jupyter images authentication (kubeflow#2591) * Updated Jupyter image paths for using in notebook controller (kubeflow#2552) * updated jupyter image paths for using in notebook conroller * removed 1.4.1 image from the list of options * updated jupyter image tags to point to the latest verified ones * updated jupyter images to allow any origin (kubeflow#2606) * Removing prune for Subresource field in CRD (kubeflow#2598) * Adding backOffLimit field to metric collector spec (kubeflow#2597) * remove global resources by label rather than listing all and looking for the label * mv client to coordinator * Fixed Dashboard v0.0.1 w/ Polymer3 + Webpack (kubeflow#2576) * Multiple issues tackled: - Fixed webpack for windows (components/ is not a valid path in windows) - Spacing and semicolons matched to old-codebase - Added cross-platform support to npm run targets - Added missing dep (babel/polyfill) - Dashboard build version is now corrected and hover will reveal kubeflow vs Dashboard versions - Pug fixed to match syntax for empty-value attributes - Updated webpack for readability * Added babel-polyfill to runtime deps rather than dev deps * [Windows-only] Color coded all make output, Tag check added, failures now have messages, also dirty git output now has a warning during build * Updated new dashboard reference :v20190227-v0.4.0-rc.1-176-g738de035 * Fixed Multiple changes: - Server port fixed to 8082 which is what is needed for GKE deployment - Refactored some code * Final working state for new image * TS Changes * Build updated to match latest :v20190301-v0.4.0-rc.1-183-g07eecd2f * Migrated dev dependency to correct location * Uncommented linter, fixed PR comments from @prodonjs * updated jupyter images based on postsubmit results of kubeflow@97b94c0 (kubeflow#2611) * Adding additional printer columns to display status (kubeflow#2609) * Adding additional printer columns to display status * Fixing tests * Semi-working kfctl go binary (kubeflow#2587) * Add flag --skip-init-gcp-project * fix gcpInitProject * update error msg * add deployment creation logic * fix bugs on generateDMData * fix bugs * add default config to ipName and hostName * fix bugs on app.yaml * add Fingerprint to update deployment * make network and gcfs as DM optional * add todos * add iam policy handlers * finish patch iam policy * adding poll op to dm api calls * add gke api version * temp * change mysqlPd/nfsPd names * remove * temp * add config types * add basic auth flag * move config to gcp * link use basic auth flag to generate * use basic auth to determine config path * change to gabrielwen repo for now * change config on the fly * change repo path * create new Genereate method * add required packages * implement NewGenerate * clean up default config and add on-the-fly configs * move config handling to ksonnet.go * add ks param set * add application as component * fix typo * add simple TargetConfiguration factory * add fixed backof * temp * fix from merge * make namespace in gke * bind user as default-admin in gke * finish createSecrets * write oauth secret * uncomment ks apply * add ks show * add ks apply logic to k8sutils * uncomment deployment * build rest.Config from remote * impersonate as admin for rbac * use remote config as REST client config * update default.yaml path * complete apply logic * add retry * add ignore * merge * remove temp comment * use backoff in gcp * remove progress as it is not updating * use backoff * use backoff * use default zone * fix zone config * add doc * add doc * update Makefile * fix flag doc * fix * doc * doc * add doc * sort packages and component names * shell out to gcloud and kubectl for now * remove some configs * fix * remove GkeApiVersion * add todo * add notebook-controller back * change names * updates * add field InitRequired * remove KsInitParams * migrate * Add status to notebook (kubeflow#2558) * wip * wip * update test to check status condition * fix * Add prodonjs to OWNERS (kubeflow#2613) * Changed sidebar tab from JupyterHub to Notebooks (kubeflow#2619) * fix (kubeflow#2620) * pf gcb (kubeflow#2603) * Setting the base_url flag of Jupyter images (kubeflow#2627) * set base_url of jupyter * change the env base_url to NB_PREFIX to sync with kubeflow#2620 * fix (kubeflow#2631) * resolve merge conflicts from upstream/master, fix error on master when --platform=none or not specified * store non exist parameter differently (kubeflow#2625) * fix (kubeflow#2632) * update pipeline system images to 0.1.12 release (kubeflow#2637) * updated jupyter image paths to point to the latest ones (kubeflow#2638) * add retry around ks init (kubeflow#2643) * add retry around ks init * update comments * merge errors * Getting started card completed (kubeflow#2651) * Getting Started card content added, and un-hidden. Windows support added in webpack to run dev builds * Getting Started card fully implemented from mocks * Spaced out cards a little more * Got eslint working! And fixed eslint issues in webpack
* Multiple issues tackled: - Fixed webpack for windows (components/ is not a valid path in windows) - Spacing and semicolons matched to old-codebase - Added cross-platform support to npm run targets - Added missing dep (babel/polyfill) - Dashboard build version is now corrected and hover will reveal kubeflow vs Dashboard versions - Pug fixed to match syntax for empty-value attributes - Updated webpack for readability * Added babel-polyfill to runtime deps rather than dev deps * [Windows-only] Color coded all make output, Tag check added, failures now have messages, also dirty git output now has a warning during build * Updated new dashboard reference :v20190227-v0.4.0-rc.1-176-g738de035 * Fixed Multiple changes: - Server port fixed to 8082 which is what is needed for GKE deployment - Refactored some code * Final working state for new image * TS Changes * Build updated to match latest :v20190301-v0.4.0-rc.1-183-g07eecd2f * Migrated dev dependency to correct location * Uncommented linter, fixed PR comments from @prodonjs
…forms' (kubeflow#2547) * revert to prior version * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'kfctl - Fetch registry automatically' * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * change DefaultDevRepo to point to just the repo not repo/kubeflow * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * plugins for all existing KfApp instances {ksonnet, minikube, foo}. * update golang version * fixes 'docker-for-desktop' * delete meta-controller-cluster-role-binding * update README.md * remove unused var DEBUG * remove bootstrap/cmd/plugins/foo.go * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'add the gcp platform to kfctl (golang)' * fix merge conflict * cli option --project is an init flag * fix to write out project to app.yaml * fix for nil project check * include fix for kubeflow#2367 * added updateDM, createSecrets to Apply * fixes to macros * merge changes from upstream master * remove old files, update README.md * fix for init app-name where app-name is not a path * fix for gcp apply * code to create a Gcp Secret, doesn't do correct auth right now * snapshot * update on downloadK8sManifests, gcpInitProject, added TODO's * additional work on gcpInitProject * gcpInitProject now works but requires GOOGLE_APPLICATION_CREDENTIALS env var * initial pass on updateDeployment * update README.md to described static vs dynamic platforms * updates to Gcp.updateDM, added GOOGLE_APPLICATION_CREDENTIALS to the Makefile tests * minor changes on init, generate usage * snapshot * additional global resources identified * do not delete scalingpolicies * change default platform to ksonnet * default --version to master until 0.5.0 * remove verbose from spark-operator apply * address comments from Jeremy * address comments from Jeremy * fixes kubeflow#2537, refer to no platform as 'none' * add general test for kfctl in Makefile that also tests the plugin capability * remove kftcl config since we now have bootstrap config, fix for DefaultPlatform="none" * change test of platform none to create directory none, updated README * remove reference to docker-for-desktop * update README.md, remove --debug flag (not used) * fixes 'kfctl (golang) Simplify the child/parent relationships in platforms' * fix backendconfig name (kubeflow#2542) * fix backendconfig name * fix test * pin to the latest verified tf-operator commit in order to enable changes in tf-operator HEAD whcih likely break kubeflow checkout tests * fix (kubeflow#2506) * Added unit tests for GetUpdatedPolicy at gcpUtils.go - bootstrap/app (kubeflow#2516) * Added tests for 'GetUpdatedPolicy' - bootstrap/app * Fix typo - gcpUtils_test.go * Added a windows equivalent script for the makefile for central-dashboard (kubeflow#2518) * update katib component (kubeflow#2553) * Refactor for Express + Webpack build stack. (kubeflow#2572) * Refactor for Express + Webpack build stack. - Add webpack to process front-end code in public/ - Add TS and Express for server backend - Update Dockerfile to run the server as Node. - Fix issue with external links. * Updates based on feedback * address review comments * move tests under test directory * Add ESLint to enforce Google JS style in public/ (kubeflow#2579) * Add ESLint to enforce Google JS style in public/ * Switch to 4 space tabs * Updating python package imports related to tf-operator (kubeflow#2581) * updated tf-operator imports * fixed a typo * fixed a typo * Profiles e2e test (kubeflow#2404) * profiles e2e test * fix * review comment * fix * fix * fix * fix * add retry * fix * Update the jupyter-web-app Image (kubeflow#2589) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * Golang profile controller (kubeflow#2533) * init * create api * wip * fix * fix * fix * fix test * address review * fix test * make it cluster scope * fix test * fix test * fix * turnoff jupyter images authentication (kubeflow#2591) * Updated Jupyter image paths for using in notebook controller (kubeflow#2552) * updated jupyter image paths for using in notebook conroller * removed 1.4.1 image from the list of options * updated jupyter image tags to point to the latest verified ones * updated jupyter images to allow any origin (kubeflow#2606) * Removing prune for Subresource field in CRD (kubeflow#2598) * Adding backOffLimit field to metric collector spec (kubeflow#2597) * remove global resources by label rather than listing all and looking for the label * mv client to coordinator * Fixed Dashboard v0.0.1 w/ Polymer3 + Webpack (kubeflow#2576) * Multiple issues tackled: - Fixed webpack for windows (components/ is not a valid path in windows) - Spacing and semicolons matched to old-codebase - Added cross-platform support to npm run targets - Added missing dep (babel/polyfill) - Dashboard build version is now corrected and hover will reveal kubeflow vs Dashboard versions - Pug fixed to match syntax for empty-value attributes - Updated webpack for readability * Added babel-polyfill to runtime deps rather than dev deps * [Windows-only] Color coded all make output, Tag check added, failures now have messages, also dirty git output now has a warning during build * Updated new dashboard reference :v20190227-v0.4.0-rc.1-176-g738de035 * Fixed Multiple changes: - Server port fixed to 8082 which is what is needed for GKE deployment - Refactored some code * Final working state for new image * TS Changes * Build updated to match latest :v20190301-v0.4.0-rc.1-183-g07eecd2f * Migrated dev dependency to correct location * Uncommented linter, fixed PR comments from @prodonjs * updated jupyter images based on postsubmit results of kubeflow@e896cd3 (kubeflow#2611) * Adding additional printer columns to display status (kubeflow#2609) * Adding additional printer columns to display status * Fixing tests * Semi-working kfctl go binary (kubeflow#2587) * Add flag --skip-init-gcp-project * fix gcpInitProject * update error msg * add deployment creation logic * fix bugs on generateDMData * fix bugs * add default config to ipName and hostName * fix bugs on app.yaml * add Fingerprint to update deployment * make network and gcfs as DM optional * add todos * add iam policy handlers * finish patch iam policy * adding poll op to dm api calls * add gke api version * temp * change mysqlPd/nfsPd names * remove * temp * add config types * add basic auth flag * move config to gcp * link use basic auth flag to generate * use basic auth to determine config path * change to gabrielwen repo for now * change config on the fly * change repo path * create new Genereate method * add required packages * implement NewGenerate * clean up default config and add on-the-fly configs * move config handling to ksonnet.go * add ks param set * add application as component * fix typo * add simple TargetConfiguration factory * add fixed backof * temp * fix from merge * make namespace in gke * bind user as default-admin in gke * finish createSecrets * write oauth secret * uncomment ks apply * add ks show * add ks apply logic to k8sutils * uncomment deployment * build rest.Config from remote * impersonate as admin for rbac * use remote config as REST client config * update default.yaml path * complete apply logic * add retry * add ignore * merge * remove temp comment * use backoff in gcp * remove progress as it is not updating * use backoff * use backoff * use default zone * fix zone config * add doc * add doc * update Makefile * fix flag doc * fix * doc * doc * add doc * sort packages and component names * shell out to gcloud and kubectl for now * remove some configs * fix * remove GkeApiVersion * add todo * add notebook-controller back * change names * updates * add field InitRequired * remove KsInitParams * migrate * Add status to notebook (kubeflow#2558) * wip * wip * update test to check status condition * fix * Add prodonjs to OWNERS (kubeflow#2613) * Changed sidebar tab from JupyterHub to Notebooks (kubeflow#2619) * fix (kubeflow#2620) * pf gcb (kubeflow#2603) * Setting the base_url flag of Jupyter images (kubeflow#2627) * set base_url of jupyter * change the env base_url to NB_PREFIX to sync with kubeflow#2620 * fix (kubeflow#2631) * resolve merge conflicts from upstream/master, fix error on master when --platform=none or not specified * store non exist parameter differently (kubeflow#2625) * fix (kubeflow#2632) * update pipeline system images to 0.1.12 release (kubeflow#2637) * updated jupyter image paths to point to the latest ones (kubeflow#2638) * add retry around ks init (kubeflow#2643) * add retry around ks init * update comments * merge errors * Getting started card completed (kubeflow#2651) * Getting Started card content added, and un-hidden. Windows support added in webpack to run dev builds * Getting Started card fully implemented from mocks * Spaced out cards a little more * Got eslint working! And fixed eslint issues in webpack
* Multiple issues tackled: - Fixed webpack for windows (components/ is not a valid path in windows) - Spacing and semicolons matched to old-codebase - Added cross-platform support to npm run targets - Added missing dep (babel/polyfill) - Dashboard build version is now corrected and hover will reveal kubeflow vs Dashboard versions - Pug fixed to match syntax for empty-value attributes - Updated webpack for readability * Added babel-polyfill to runtime deps rather than dev deps * [Windows-only] Color coded all make output, Tag check added, failures now have messages, also dirty git output now has a warning during build * Updated new dashboard reference :v20190227-v0.4.0-rc.1-176-g738de035 * Fixed Multiple changes: - Server port fixed to 8082 which is what is needed for GKE deployment - Refactored some code * Final working state for new image * TS Changes * Build updated to match latest :v20190301-v0.4.0-rc.1-183-g07eecd2f * Migrated dev dependency to correct location * Uncommented linter, fixed PR comments from @prodonjs
…forms' (kubeflow#2547) * revert to prior version * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'kfctl - Fetch registry automatically' * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * change DefaultDevRepo to point to just the repo not repo/kubeflow * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * plugins for all existing KfApp instances {ksonnet, minikube, foo}. * update golang version * fixes 'docker-for-desktop' * delete meta-controller-cluster-role-binding * update README.md * remove unused var DEBUG * remove bootstrap/cmd/plugins/foo.go * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'add the gcp platform to kfctl (golang)' * fix merge conflict * cli option --project is an init flag * fix to write out project to app.yaml * fix for nil project check * include fix for kubeflow#2367 * added updateDM, createSecrets to Apply * fixes to macros * merge changes from upstream master * remove old files, update README.md * fix for init app-name where app-name is not a path * fix for gcp apply * code to create a Gcp Secret, doesn't do correct auth right now * snapshot * update on downloadK8sManifests, gcpInitProject, added TODO's * additional work on gcpInitProject * gcpInitProject now works but requires GOOGLE_APPLICATION_CREDENTIALS env var * initial pass on updateDeployment * update README.md to described static vs dynamic platforms * updates to Gcp.updateDM, added GOOGLE_APPLICATION_CREDENTIALS to the Makefile tests * minor changes on init, generate usage * snapshot * additional global resources identified * do not delete scalingpolicies * change default platform to ksonnet * default --version to master until 0.5.0 * remove verbose from spark-operator apply * address comments from Jeremy * address comments from Jeremy * fixes kubeflow#2537, refer to no platform as 'none' * add general test for kfctl in Makefile that also tests the plugin capability * remove kftcl config since we now have bootstrap config, fix for DefaultPlatform="none" * change test of platform none to create directory none, updated README * remove reference to docker-for-desktop * update README.md, remove --debug flag (not used) * fixes 'kfctl (golang) Simplify the child/parent relationships in platforms' * fix backendconfig name (kubeflow#2542) * fix backendconfig name * fix test * pin to the latest verified tf-operator commit in order to enable changes in tf-operator HEAD whcih likely break kubeflow checkout tests * fix (kubeflow#2506) * Added unit tests for GetUpdatedPolicy at gcpUtils.go - bootstrap/app (kubeflow#2516) * Added tests for 'GetUpdatedPolicy' - bootstrap/app * Fix typo - gcpUtils_test.go * Added a windows equivalent script for the makefile for central-dashboard (kubeflow#2518) * update katib component (kubeflow#2553) * Refactor for Express + Webpack build stack. (kubeflow#2572) * Refactor for Express + Webpack build stack. - Add webpack to process front-end code in public/ - Add TS and Express for server backend - Update Dockerfile to run the server as Node. - Fix issue with external links. * Updates based on feedback * address review comments * move tests under test directory * Add ESLint to enforce Google JS style in public/ (kubeflow#2579) * Add ESLint to enforce Google JS style in public/ * Switch to 4 space tabs * Updating python package imports related to tf-operator (kubeflow#2581) * updated tf-operator imports * fixed a typo * fixed a typo * Profiles e2e test (kubeflow#2404) * profiles e2e test * fix * review comment * fix * fix * fix * fix * add retry * fix * Update the jupyter-web-app Image (kubeflow#2589) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * Golang profile controller (kubeflow#2533) * init * create api * wip * fix * fix * fix * fix test * address review * fix test * make it cluster scope * fix test * fix test * fix * turnoff jupyter images authentication (kubeflow#2591) * Updated Jupyter image paths for using in notebook controller (kubeflow#2552) * updated jupyter image paths for using in notebook conroller * removed 1.4.1 image from the list of options * updated jupyter image tags to point to the latest verified ones * updated jupyter images to allow any origin (kubeflow#2606) * Removing prune for Subresource field in CRD (kubeflow#2598) * Adding backOffLimit field to metric collector spec (kubeflow#2597) * remove global resources by label rather than listing all and looking for the label * mv client to coordinator * Fixed Dashboard v0.0.1 w/ Polymer3 + Webpack (kubeflow#2576) * Multiple issues tackled: - Fixed webpack for windows (components/ is not a valid path in windows) - Spacing and semicolons matched to old-codebase - Added cross-platform support to npm run targets - Added missing dep (babel/polyfill) - Dashboard build version is now corrected and hover will reveal kubeflow vs Dashboard versions - Pug fixed to match syntax for empty-value attributes - Updated webpack for readability * Added babel-polyfill to runtime deps rather than dev deps * [Windows-only] Color coded all make output, Tag check added, failures now have messages, also dirty git output now has a warning during build * Updated new dashboard reference :v20190227-v0.4.0-rc.1-176-g738de035 * Fixed Multiple changes: - Server port fixed to 8082 which is what is needed for GKE deployment - Refactored some code * Final working state for new image * TS Changes * Build updated to match latest :v20190301-v0.4.0-rc.1-183-g07eecd2f * Migrated dev dependency to correct location * Uncommented linter, fixed PR comments from @prodonjs * updated jupyter images based on postsubmit results of kubeflow@598dd06 (kubeflow#2611) * Adding additional printer columns to display status (kubeflow#2609) * Adding additional printer columns to display status * Fixing tests * Semi-working kfctl go binary (kubeflow#2587) * Add flag --skip-init-gcp-project * fix gcpInitProject * update error msg * add deployment creation logic * fix bugs on generateDMData * fix bugs * add default config to ipName and hostName * fix bugs on app.yaml * add Fingerprint to update deployment * make network and gcfs as DM optional * add todos * add iam policy handlers * finish patch iam policy * adding poll op to dm api calls * add gke api version * temp * change mysqlPd/nfsPd names * remove * temp * add config types * add basic auth flag * move config to gcp * link use basic auth flag to generate * use basic auth to determine config path * change to gabrielwen repo for now * change config on the fly * change repo path * create new Genereate method * add required packages * implement NewGenerate * clean up default config and add on-the-fly configs * move config handling to ksonnet.go * add ks param set * add application as component * fix typo * add simple TargetConfiguration factory * add fixed backof * temp * fix from merge * make namespace in gke * bind user as default-admin in gke * finish createSecrets * write oauth secret * uncomment ks apply * add ks show * add ks apply logic to k8sutils * uncomment deployment * build rest.Config from remote * impersonate as admin for rbac * use remote config as REST client config * update default.yaml path * complete apply logic * add retry * add ignore * merge * remove temp comment * use backoff in gcp * remove progress as it is not updating * use backoff * use backoff * use default zone * fix zone config * add doc * add doc * update Makefile * fix flag doc * fix * doc * doc * add doc * sort packages and component names * shell out to gcloud and kubectl for now * remove some configs * fix * remove GkeApiVersion * add todo * add notebook-controller back * change names * updates * add field InitRequired * remove KsInitParams * migrate * Add status to notebook (kubeflow#2558) * wip * wip * update test to check status condition * fix * Add prodonjs to OWNERS (kubeflow#2613) * Changed sidebar tab from JupyterHub to Notebooks (kubeflow#2619) * fix (kubeflow#2620) * pf gcb (kubeflow#2603) * Setting the base_url flag of Jupyter images (kubeflow#2627) * set base_url of jupyter * change the env base_url to NB_PREFIX to sync with kubeflow#2620 * fix (kubeflow#2631) * resolve merge conflicts from upstream/master, fix error on master when --platform=none or not specified * store non exist parameter differently (kubeflow#2625) * fix (kubeflow#2632) * update pipeline system images to 0.1.12 release (kubeflow#2637) * updated jupyter image paths to point to the latest ones (kubeflow#2638) * add retry around ks init (kubeflow#2643) * add retry around ks init * update comments * merge errors * Getting started card completed (kubeflow#2651) * Getting Started card content added, and un-hidden. Windows support added in webpack to run dev builds * Getting Started card fully implemented from mocks * Spaced out cards a little more * Got eslint working! And fixed eslint issues in webpack
Child of #2359
fixes #2582
/assign @avdaredevil
/assign @prodonjs
/cc @jlewi
This change is